+Cleanup of framework module use and wrapping #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused module use statements in various modules, to help eliminate apparent but inaccurate module dependencies, and to facilitate the migration to FMS2. All answers are bitwise identical.
Use MOM framework interfaces in MOM_open_boundary in place of direct calls to mpp routines, to facilitate the migration to FMS2. All answers are bitwise identical.
Use MOM_read_data in place of read_data in RGC_initialization to match the routines used in other modules and facilitate migration to FMS2. All answers are bitwise identical.
Expanded the SZI_ and SZJ_ macros in random_2d_ routines to eliminate any dependence on MOM_memory.h and facilitate the future compilation of MOM_random as a part of a MOM framework library. All answers are bitwise identical.
Added the new routine read_field_chksum to MOM_io.F90, so that all calls to the FMS i/o layer can be directed via MOM_io.F90, in order to facilitate the painless and compartmentalized migration to FMS2. Also added a 0-d variant for MOM_read_data, and standardized the control-flag and subroutine aliases used in MOM_io.F90. All answers are bitwise identical, but there are new public interfaces.
Use read_field_chksum and MOM_read_data in MOM_restart. Also internally renamed mpp_chksum to just chksum in MOM_restart to aid in identifying unfiltered dependencies on FMS in MOM_restart.F90. All answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1280 +/- ##
============================================
- Coverage 45.88% 45.88% -0.01%
============================================
Files 225 225
Lines 71422 71428 +6
============================================
- Hits 32774 32772 -2
- Misses 38648 38656 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up or eliminates module use statements related to the framework
code and makes minor changes the framework code to localize the dependencies on
the FMS framework into fewer files. This should be helpful for scoping out an
appropriate and limited set of changes for the migration to use FMS2, and all of
these are no-regrets changes that will not alter answers or output. The list of
commits in this PR include: